CodeDevMLH/jellyfin-plugin-media-bar-enhanced
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 24 Wiki Activity

Refactor slide playback logic to improve active slide checks and remove commented code

Browse Source
This commit is contained in:
CodeDevMLH
2026-02-13 19:34:13 +01:00
parent 1ae59f5da5
commit 7992e20715
1 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
Jellyfin.Plugin.MediaBarEnhanced/Web/mediaBarEnhanced.js
View File

@@ -1490,7 +1490,6 @@ const VisibilityObserver = {
* Initializes visibility observer * Initializes visibility observer
*/ */
init() { init() {
// MARK: Mark
const observer = new MutationObserver(() => this.updateVisibility()); const observer = new MutationObserver(() => this.updateVisibility());
// let debounceTimer = null; // let debounceTimer = null;
// const observer = new MutationObserver(() => { // const observer = new MutationObserver(() => {
@@ -1744,14 +1743,15 @@ const SlideCreator = {
if (slide && slide.classList.contains('active') && !document.hidden && (!isVideoPlayerOpen || isVideoPlayerOpen.classList.contains('hide'))) { if (slide && slide.classList.contains('active') && !document.hidden && (!isVideoPlayerOpen || isVideoPlayerOpen.classList.contains('hide'))) {
// MARK: mark // MARK: mark
// const currentIndex = STATE.slideshow.currentSlideIndex; const currentIndex = STATE.slideshow.currentSlideIndex;
// const currentItemId = STATE.slideshow.itemIds[currentIndex]; const currentItemId = STATE.slideshow.itemIds[currentIndex];
// if (currentItemId !== itemId) { if (currentItemId !== itemId) {
// console.log(`Slide ${itemId} is no longer active (current: ${currentItemId}), aborting playback.`); console.log(`Slide ${itemId} is no longer active (current: ${currentItemId}), aborting playback.`);
// event.target.mute(); // Mute just in case event.target.mute(); // Mute just in case
// return; return;
// } }
event.target.playVideo();
event.target.playVideo();
// Check if it actually started playing after a short delay (handling autoplay blocks) // Check if it actually started playing after a short delay (handling autoplay blocks)
const timeoutId = setTimeout(() => { const timeoutId = setTimeout(() => {
@@ -1828,12 +1828,12 @@ const SlideCreator = {
backdrop.addEventListener('play', (event) => { backdrop.addEventListener('play', (event) => {
const slide = document.querySelector(`.slide[data-item-id="${itemId}"]`); const slide = document.querySelector(`.slide[data-item-id="${itemId}"]`);
// MARK: mark // MARK: mark
// const currentIndex = STATE.slideshow.currentSlideIndex; const currentIndex = STATE.slideshow.currentSlideIndex;
// const currentItemId = STATE.slideshow.itemIds[currentIndex]; const currentItemId = STATE.slideshow.itemIds[currentIndex];
// if (!slide || !slide.classList.contains('active') || currentItemId !== itemId) { if (!slide || !slide.classList.contains('active') || currentItemId !== itemId) {
if (!slide || !slide.classList.contains('active')) { // if (!slide || !slide.classList.contains('active')) {
console.log(`Local video ${itemId} started playing but is not active, pausing.`); console.log(`Local video ${itemId} started playing but is not active, pausing.`);
event.target.pause(); event.target.pause();
event.target.currentTime = 0; event.target.currentTime = 0;
@@ -2712,7 +2712,9 @@ const SlideshowManager = {
videoBackdrop.play().catch(() => { videoBackdrop.play().catch(() => {
setTimeout(() => { setTimeout(() => {
if (videoBackdrop.paused) { // MARK: mark
if (videoBackdrop.paused && slide.classList.contains('active')) {
// if (videoBackdrop.paused) {
console.warn(`Autoplay blocked for ${itemId}, attempting muted fallback`); console.warn(`Autoplay blocked for ${itemId}, attempting muted fallback`);
videoBackdrop.muted = true; videoBackdrop.muted = true;
videoBackdrop.play().catch(err => console.error("Muted fallback failed", err)); videoBackdrop.play().catch(err => console.error("Muted fallback failed", err));
@@ -2739,6 +2741,9 @@ const SlideshowManager = {
} }
setTimeout(() => { setTimeout(() => {
// MARK: mark
if (!slide.classList.contains('active')) return;
if (player.getPlayerState && if (player.getPlayerState &&
player.getPlayerState() !== YT.PlayerState.PLAYING && player.getPlayerState() !== YT.PlayerState.PLAYING &&
player.getPlayerState() !== YT.PlayerState.BUFFERING) { player.getPlayerState() !== YT.PlayerState.BUFFERING) {