Refactor slide playback logic to improve active slide checks and remove commented code

This commit is contained in:
CodeDevMLH
2026-02-13 19:34:13 +01:00
parent 1ae59f5da5
commit 7992e20715

View File

@@ -1490,7 +1490,6 @@ const VisibilityObserver = {
* Initializes visibility observer
*/
init() {
// MARK: Mark
const observer = new MutationObserver(() => this.updateVisibility());
// let debounceTimer = null;
// const observer = new MutationObserver(() => {
@@ -1744,14 +1743,15 @@ const SlideCreator = {
if (slide && slide.classList.contains('active') && !document.hidden && (!isVideoPlayerOpen || isVideoPlayerOpen.classList.contains('hide'))) {
// MARK: mark
// const currentIndex = STATE.slideshow.currentSlideIndex;
// const currentItemId = STATE.slideshow.itemIds[currentIndex];
// if (currentItemId !== itemId) {
// console.log(`Slide ${itemId} is no longer active (current: ${currentItemId}), aborting playback.`);
// event.target.mute(); // Mute just in case
// return;
// }
event.target.playVideo();
const currentIndex = STATE.slideshow.currentSlideIndex;
const currentItemId = STATE.slideshow.itemIds[currentIndex];
if (currentItemId !== itemId) {
console.log(`Slide ${itemId} is no longer active (current: ${currentItemId}), aborting playback.`);
event.target.mute(); // Mute just in case
return;
}
event.target.playVideo();
// Check if it actually started playing after a short delay (handling autoplay blocks)
const timeoutId = setTimeout(() => {
@@ -1828,12 +1828,12 @@ const SlideCreator = {
backdrop.addEventListener('play', (event) => {
const slide = document.querySelector(`.slide[data-item-id="${itemId}"]`);
// MARK: mark
// const currentIndex = STATE.slideshow.currentSlideIndex;
// const currentItemId = STATE.slideshow.itemIds[currentIndex];
const currentIndex = STATE.slideshow.currentSlideIndex;
const currentItemId = STATE.slideshow.itemIds[currentIndex];
// if (!slide || !slide.classList.contains('active') || currentItemId !== itemId) {
if (!slide || !slide.classList.contains('active') || currentItemId !== itemId) {
if (!slide || !slide.classList.contains('active')) {
// if (!slide || !slide.classList.contains('active')) {
console.log(`Local video ${itemId} started playing but is not active, pausing.`);
event.target.pause();
event.target.currentTime = 0;
@@ -2712,7 +2712,9 @@ const SlideshowManager = {
videoBackdrop.play().catch(() => {
setTimeout(() => {
if (videoBackdrop.paused) {
// MARK: mark
if (videoBackdrop.paused && slide.classList.contains('active')) {
// if (videoBackdrop.paused) {
console.warn(`Autoplay blocked for ${itemId}, attempting muted fallback`);
videoBackdrop.muted = true;
videoBackdrop.play().catch(err => console.error("Muted fallback failed", err));
@@ -2739,6 +2741,9 @@ const SlideshowManager = {
}
setTimeout(() => {
// MARK: mark
if (!slide.classList.contains('active')) return;
if (player.getPlayerState &&
player.getPlayerState() !== YT.PlayerState.PLAYING &&
player.getPlayerState() !== YT.PlayerState.BUFFERING) {