feat: Update to version 1.2.0.0 with script injection improvements and fallback support

Jellyfin.Plugin.Seasonals/Jellyfin.Plugin.Seasonals.csproj

@@ -12,13 +12,14 @@
     <!-- <TreatWarningsAsErrors>false</TreatWarningsAsErrors> -->
     <Title>Jellyfin Seasonals Plugin</Title>
     <Authors>CodeDevMLH</Authors>
-    <Version>1.1.0.0</Version>
+    <Version>1.2.0.0</Version>
     <RepositoryUrl>https://github.com/CodeDevMLH/jellyfin-plugin-seasonals</RepositoryUrl>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Jellyfin.Controller" Version="$(JellyfinVersion)" />
     <PackageReference Include="Jellyfin.Model" Version="$(JellyfinVersion)" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
   </ItemGroup>
 
   <ItemGroup>

Jellyfin.Plugin.Seasonals/Plugin.cs

@@ -1,12 +1,17 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
+using System.Linq;
+using System.Reflection;
+using System.Runtime.Loader;
 using Jellyfin.Plugin.Seasonals.Configuration;
 using MediaBrowser.Common.Configuration;
 using MediaBrowser.Common.Plugins;
 using MediaBrowser.Model.Plugins;
 using MediaBrowser.Model.Serialization;
 using Microsoft.Extensions.Logging;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 
 namespace Jellyfin.Plugin.Seasonals;
 
@@ -28,7 +33,10 @@ public class Plugin : BasePlugin<PluginConfiguration>, IHasWebPages
     {
         Instance = this;
         _scriptInjector = new ScriptInjector(applicationPaths, loggerFactory.CreateLogger<ScriptInjector>());
-        _scriptInjector.Inject();
+        if (!_scriptInjector.Inject())
+        {
+            TryRegisterFallback(loggerFactory.CreateLogger("FileTransformationFallback"));
+        }
     }
 
     /// <inheritdoc />
@@ -42,16 +50,99 @@ public class Plugin : BasePlugin<PluginConfiguration>, IHasWebPages
     /// </summary>
     public static Plugin? Instance { get; private set; }
 
+    /// <summary>
+    /// Callback method for FileTransformation plugin.
+    /// </summary>
+    /// <param name="payload">The payload containing the file contents.</param>
+    /// <returns>The modified file contents.</returns>
+    public static string TransformIndexHtml(JObject payload)
+    {
+        // CRITICAL: Always return original content if something fails or is null
+        string? originalContents = payload?["contents"]?.ToString();
+        
+        if (string.IsNullOrEmpty(originalContents))
+        {
+            return originalContents ?? string.Empty;
+        }
+
+        try
+        {
+            var html = originalContents;
+            const string inject = "<script src=\"/Seasonals/Resources/seasonals.js\"></script>\n<body";
+            
+            if (!html.Contains("seasonals.js", StringComparison.Ordinal))
+            {
+                return html.Replace("<body", inject, StringComparison.OrdinalIgnoreCase);
+            }
+            
+            return html;
+        }
+        catch
+        {
+            // On error, return original content to avoid breaking the UI
+            return originalContents;
+        }
+    }
+
+    private void TryRegisterFallback(ILogger logger)
+    {
+        try
+        {
+            // Find the FileTransformation assembly across all load contexts
+            var assembly = AssemblyLoadContext.All
+                .SelectMany(x => x.Assemblies)
+                .FirstOrDefault(x => x.FullName?.Contains(".FileTransformation") ?? false);
+
+            if (assembly == null)
+            {
+                logger.LogWarning("FileTransformation plugin not found. Fallback injection skipped.");
+                return;
+            }
+
+            var type = assembly.GetType("Jellyfin.Plugin.FileTransformation.PluginInterface");
+            if (type == null)
+            {
+                logger.LogWarning("Jellyfin.Plugin.FileTransformation.PluginInterface not found.");
+                return;
+            }
+
+            var method = type.GetMethod("RegisterTransformation");
+            if (method == null)
+            {
+                logger.LogWarning("RegisterTransformation method not found.");
+                return;
+            }
+
+            // Create JObject payload directly using Newtonsoft.Json
+            var payload = new JObject
+            {
+                { "id", Id.ToString() },
+                { "fileNamePattern", "index.html" },
+                { "callbackAssembly", this.GetType().Assembly.FullName },
+                { "callbackClass", this.GetType().FullName },
+                { "callbackMethod", nameof(TransformIndexHtml) }
+            };
+
+            // Invoke RegisterTransformation with the JObject payload
+            method.Invoke(null, new object[] { payload });
+            logger.LogInformation("Successfully registered fallback transformation via FileTransformation plugin.");
+        }
+        catch (Exception ex)
+        {
+            logger.LogError(ex, "Error attempting to register fallback transformation.");
+        }
+    }
+
     /// <inheritdoc />
     public IEnumerable<PluginPageInfo> GetPages()
     {
-        return
-        [
+        return new[]
+        {
             new PluginPageInfo
             {
                 Name = Name,
                 EmbeddedResourcePath = string.Format(CultureInfo.InvariantCulture, "{0}.Configuration.configPage.html", GetType().Namespace)
             }
-        ];
+        };
     }
 }

Jellyfin.Plugin.Seasonals/ScriptInjector.cs

@@ -13,7 +13,7 @@ public class ScriptInjector
 {
     private readonly IApplicationPaths _appPaths;
     private readonly ILogger<ScriptInjector> _logger;
-    private const string ScriptTag = "<script src=\"Seasonals/Resources/seasonals.js\"></script>";
+    private const string ScriptTag = "<script src=\"/Seasonals/Resources/seasonals.js\"></script>";
     private const string Marker = "</body>";
 
     /// <summary>
@@ -30,7 +30,8 @@ public class ScriptInjector
     /// <summary>
     /// Injects the script tag into index.html if it's not already present.
     /// </summary>
-    public void Inject()
+    /// <returns>True if injection was successful or already present, false otherwise.</returns>
+    public bool Inject()
     {
         try
         {
@@ -38,21 +39,21 @@ public class ScriptInjector
             if (string.IsNullOrEmpty(webPath))
             {
                 _logger.LogWarning("Could not find Jellyfin web path. Script injection skipped.");
-                return;
+                return false;
             }
 
             var indexPath = Path.Combine(webPath, "index.html");
             if (!File.Exists(indexPath))
             {
                 _logger.LogWarning("index.html not found at {Path}. Script injection skipped.", indexPath);
-                return;
+                return false;
             }
 
             var content = File.ReadAllText(indexPath);
             if (content.Contains(ScriptTag, StringComparison.Ordinal))
             {
                 _logger.LogInformation("Seasonals script already injected.");
-                return;
+                return true;
             }
 
             // Insert before the closing body tag
@@ -60,15 +61,22 @@ public class ScriptInjector
             if (string.Equals(newContent, content, StringComparison.Ordinal))
             {
                 _logger.LogWarning("Could not find closing body tag in index.html. Script injection skipped.");
-                return;
+                return false;
             }
 
             File.WriteAllText(indexPath, newContent);
             _logger.LogInformation("Successfully injected Seasonals script into index.html.");
+            return true;
+        }
+        catch (UnauthorizedAccessException)
+        {
+            _logger.LogWarning("Permission denied when attempting to inject script into index.html. Automatic injection failed. Please ensure the Jellyfin web directory is writable by the process, or manually add the script tag: {ScriptTag}", ScriptTag);
+            return false;
         }
         catch (Exception ex)
         {
             _logger.LogError(ex, "Error injecting Seasonals script.");
+            return false;
         }
     }
 
@@ -104,6 +112,10 @@ public class ScriptInjector
             File.WriteAllText(indexPath, newContent);
             _logger.LogInformation("Successfully removed Seasonals script from index.html.");
         }
+        catch (UnauthorizedAccessException)
+        {
+            _logger.LogWarning("Permission denied when attempting to remove script from index.html.");
+        }
         catch (Exception ex)
         {
             _logger.LogError(ex, "Error removing Seasonals script.");

Jellyfin.Plugin.Seasonals/Web/seasonals.js

@@ -162,6 +162,7 @@ async function initializeTheme() {
             automateThemeSelection = config.automateSeasonSelection;
             defaultTheme = config.selectedSeason;
             window.SeasonalsPluginConfig = config;
+            console.log('Seasonals Config loaded:', config);
         } else {
             console.error('Failed to fetch Seasonals config');
         }
@@ -170,7 +171,7 @@ async function initializeTheme() {
     }
 
     let currentTheme;
-    if (!automateThemeSelection) {
+    if (automateThemeSelection === false) {
         currentTheme = defaultTheme;
     } else {
         currentTheme = determineCurrentTheme();
@@ -178,7 +179,7 @@ async function initializeTheme() {
 
     console.log(`Selected theme: ${currentTheme}`);
 
-    if (currentTheme === 'none') {
+    if (!currentTheme || currentTheme === 'none') {
         console.log('No theme selected.');
         removeSelf();
         return;
@@ -200,8 +201,9 @@ async function initializeTheme() {
     removeSelf();
 }
 
-
-//document.addEventListener('DOMContentLoaded', initializeTheme);
-document.addEventListener('DOMContentLoaded', () => {
+// Ensure DOM is ready before initializing
+if (document.readyState === 'loading') {
+    document.addEventListener('DOMContentLoaded', initializeTheme);
+} else {
     initializeTheme();
-});
+}

bin/Publish/Jellyfin.Plugin.Seasonals.deps.json

@@ -6,10 +6,11 @@
   "compilationOptions": {},
   "targets": {
     ".NETCoreApp,Version=v9.0": {
-      "Jellyfin.Plugin.Seasonals/1.1.0.0": {
+      "Jellyfin.Plugin.Seasonals/1.2.0.0": {
         "dependencies": {
           "Jellyfin.Controller": "10.11.0",
-          "Jellyfin.Model": "10.11.0"
+          "Jellyfin.Model": "10.11.0",
+          "Newtonsoft.Json": "13.0.4"
         },
         "runtime": {
           "Jellyfin.Plugin.Seasonals.dll": {}
@@ -326,6 +327,14 @@
           }
         }
       },
+      "Newtonsoft.Json/13.0.4": {
+        "runtime": {
+          "lib/net6.0/Newtonsoft.Json.dll": {
+            "assemblyVersion": "13.0.0.0",
+            "fileVersion": "13.0.4.30916"
+          }
+        }
+      },
       "Polly/8.6.4": {
         "dependencies": {
           "Polly.Core": "8.6.4"
@@ -363,7 +372,7 @@
     }
   },
   "libraries": {
-    "Jellyfin.Plugin.Seasonals/1.1.0.0": {
+    "Jellyfin.Plugin.Seasonals/1.2.0.0": {
       "type": "project",
       "serviceable": false,
       "sha512": ""
@@ -578,6 +587,13 @@
       "path": "nebml/1.1.0.5",
       "hashPath": "nebml.1.1.0.5.nupkg.sha512"
     },
+    "Newtonsoft.Json/13.0.4": {
+      "type": "package",
+      "serviceable": true,
+      "sha512": "sha512-pdgNNMai3zv51W5aq268sujXUyx7SNdE2bj1wZcWjAQrKMFZV260lbqYop1d2GM67JI1huLRwxo9ZqnfF/lC6A==",
+      "path": "newtonsoft.json/13.0.4",
+      "hashPath": "newtonsoft.json.13.0.4.nupkg.sha512"
+    },
     "Polly/8.6.4": {
       "type": "package",
       "serviceable": true,

build.yaml

@@ -1,7 +1,7 @@
 ---
 name: "Seasonals"
 guid: "ef1e863f-cbb0-4e47-9f23-f0cbb1826ad4"
-version: "1.1.0.0"
+version: "1.2.0.0"
 targetAbi: "10.11.0.0"
 framework: "net9.0"
 overview: "Seasonal effects for Jellyfin"

feat/Jellyfin.Plugin.Seasonals.csproj

@@ -0,0 +1,34 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <JellyfinVersion>10.11.0</JellyfinVersion>
+    <TargetFramework Condition="$(JellyfinVersion.StartsWith('10.11'))">net9.0</TargetFramework>
+    <TargetFramework Condition="!$(JellyfinVersion.StartsWith('10.11'))">net8.0</TargetFramework>
+    <RootNamespace>Jellyfin.Plugin.Seasonals</RootNamespace>
+    <Nullable>enable</Nullable>
+    <!-- <AnalysisMode>AllEnabledByDefault</AnalysisMode> -->
+    <!-- <CodeAnalysisRuleSet>../jellyfin.ruleset</CodeAnalysisRuleSet> -->
+    <!-- <GenerateDocumentationFile>true</GenerateDocumentationFile> -->
+    <!-- <TreatWarningsAsErrors>false</TreatWarningsAsErrors> -->
+    <Title>Jellyfin Seasonals Plugin</Title>
+    <Authors>CodeDevMLH</Authors>
+    <Version>1.1.0.0</Version>
+    <RepositoryUrl>https://github.com/CodeDevMLH/jellyfin-plugin-seasonals</RepositoryUrl>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Jellyfin.Controller" Version="$(JellyfinVersion)" />
+    <PackageReference Include="Jellyfin.Model" Version="$(JellyfinVersion)" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <None Remove="Configuration\configPage.html" />
+    <EmbeddedResource Include="Configuration\configPage.html" />
+    <None Remove="Web\**" />
+    <EmbeddedResource Include="Web\**" />
+
+    <None Include="..\README.md" />
+    <None Include="..\logo.png" CopyToOutputDirectory="Always" />
+  </ItemGroup>
+
+</Project>

feat/Plugin.cs

@@ -0,0 +1,50 @@
+using System;
+using System.Collections.Generic;
+using Jellyfin.Plugin.Seasonals.Configuration;
+using MediaBrowser.Common.Configuration;
+using MediaBrowser.Common.Plugins;
+using MediaBrowser.Model.Plugins;
+using MediaBrowser.Model.Serialization;
+
+namespace Jellyfin.Plugin.Seasonals;
+
+/// <summary>
+/// The main plugin.
+/// </summary>
+public class Plugin : BasePlugin<PluginConfiguration>, IHasWebPages
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="Plugin"/> class.
+    /// </summary>
+    /// <param name="applicationPaths">Instance of the <see cref="IApplicationPaths"/> interface.</param>
+    /// <param name="xmlSerializer">Instance of the <see cref="IXmlSerializer"/> interface.</param>
+    public Plugin(IApplicationPaths applicationPaths, IXmlSerializer xmlSerializer)
+        : base(applicationPaths, xmlSerializer)
+    {
+        Instance = this;
+    }
+
+    /// <inheritdoc />
+    public override string Name => "Seasonals";
+
+    /// <inheritdoc />
+    public override Guid Id => Guid.Parse("ef1e863f-cbb0-4e47-9f23-f0cbb1826ad4");
+
+    /// <summary>
+    /// Gets the current plugin instance.
+    /// </summary>
+    public static Plugin? Instance { get; private set; }
+
+    /// <inheritdoc />
+    public IEnumerable<PluginPageInfo> GetPages()
+    {
+        return
+        [
+            new PluginPageInfo
+            {
+                Name = "seasonals",
+                EmbeddedResourcePath = GetType().Namespace + ".Configuration.configPage.html"
+            }
+        ];
+    }
+}

feat/PluginServiceRegistrator.cs

@@ -0,0 +1,18 @@
+using MediaBrowser.Controller;
+using MediaBrowser.Controller.Plugins;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace Jellyfin.Plugin.Seasonals;
+
+/// <summary>
+/// Registers plugin services.
+/// </summary>
+public class PluginServiceRegistrator : IPluginServiceRegistrator
+{
+    /// <inheritdoc />
+    public void RegisterServices(IServiceCollection serviceCollection, IServerApplicationHost applicationHost)
+    {
+        serviceCollection.AddTransient<IStartupFilter, ScriptInjectionStartupFilter>();
+    }
+}

feat/ScriptInjectionMiddleware.cs

@@ -0,0 +1,102 @@
+using System;
+using System.IO;
+using System.Text;
+using System.Threading.Tasks;
+using Microsoft.AspNetCore.Http;
+using Microsoft.Extensions.Logging;
+
+namespace Jellyfin.Plugin.Seasonals;
+
+/// <summary>
+/// Middleware to inject the Seasonals script into the Jellyfin web interface.
+/// </summary>
+public class ScriptInjectionMiddleware
+{
+    private readonly RequestDelegate _next;
+    private readonly ILogger<ScriptInjectionMiddleware> _logger;
+    private const string ScriptTag = "<script src=\"Seasonals/Resources/seasonals.js\"></script>";
+    private const string Marker = "</body>";
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ScriptInjectionMiddleware"/> class.
+    /// </summary>
+    /// <param name="next">The next delegate in the pipeline.</param>
+    /// <param name="logger">The logger.</param>
+    public ScriptInjectionMiddleware(RequestDelegate next, ILogger<ScriptInjectionMiddleware> logger)
+    {
+        _next = next;
+        _logger = logger;
+    }
+
+    /// <summary>
+    /// Invokes the middleware.
+    /// </summary>
+    /// <param name="context">The HTTP context.</param>
+    /// <returns>A task representing the asynchronous operation.</returns>
+    public async Task InvokeAsync(HttpContext context)
+    {
+        if (IsIndexRequest(context.Request.Path))
+        {
+            var originalBodyStream = context.Response.Body;
+            using var responseBody = new MemoryStream();
+            context.Response.Body = responseBody;
+
+            try
+            {
+                await _next(context);
+
+                context.Response.Body = originalBodyStream;
+                responseBody.Seek(0, SeekOrigin.Begin);
+
+                if (context.Response.StatusCode == 200 &&
+                    context.Response.ContentType != null &&
+                    context.Response.ContentType.Contains("text/html", StringComparison.OrdinalIgnoreCase))
+                {
+                    using var reader = new StreamReader(responseBody);
+                    var content = await reader.ReadToEndAsync();
+
+                    if (!content.Contains(ScriptTag, StringComparison.Ordinal) && content.Contains(Marker, StringComparison.Ordinal))
+                    {
+                        var newContent = content.Replace(Marker, $"{ScriptTag}\n{Marker}", StringComparison.Ordinal);
+                        var bytes = Encoding.UTF8.GetBytes(newContent);
+                        
+                        context.Response.ContentLength = bytes.Length;
+                        await context.Response.Body.WriteAsync(bytes, 0, bytes.Length);
+                        return;
+                    }
+                }
+
+                responseBody.Seek(0, SeekOrigin.Begin);
+                await responseBody.CopyToAsync(originalBodyStream);
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, "Error injecting Seasonals script via middleware.");
+                // Ensure we try to write back the original response if something failed
+                if (responseBody.Length > 0 && context.Response.Body == originalBodyStream)
+                {
+                    responseBody.Seek(0, SeekOrigin.Begin);
+                    await responseBody.CopyToAsync(originalBodyStream);
+                }
+            }
+        }
+        else
+        {
+            await _next(context);
+        }
+    }
+
+    private static bool IsIndexRequest(PathString path)
+    {
+        if (!path.HasValue)
+        {
+            return false;
+        }
+
+        var p = path.Value;
+        // Check for root, index.html, or web/index.html
+        return p.Equals("/", StringComparison.OrdinalIgnoreCase) ||
+               p.Equals("/index.html", StringComparison.OrdinalIgnoreCase) ||
+               p.EndsWith("/web/index.html", StringComparison.OrdinalIgnoreCase);
+    }
+}

feat/ScriptInjectionStartupFilter.cs

@@ -0,0 +1,21 @@
+using System;
+using Microsoft.AspNetCore.Builder;
+using Microsoft.AspNetCore.Hosting;
+
+namespace Jellyfin.Plugin.Seasonals;
+
+/// <summary>
+/// Startup filter to register the ScriptInjectionMiddleware.
+/// </summary>
+public class ScriptInjectionStartupFilter : IStartupFilter
+{
+    /// <inheritdoc />
+    public Action<IApplicationBuilder> Configure(Action<IApplicationBuilder> next)
+    {
+        return builder =>
+        {
+            builder.UseMiddleware<ScriptInjectionMiddleware>();
+            next(builder);
+        };
+    }
+}

manifest-v1.json

@@ -0,0 +1,21 @@
+[
+  {
+    "guid": "ef1e863f-cbb0-4e47-9f23-f0cbb1826ad4",
+    "name": "Seasonals",
+    "description": "Adds seasonal effects like snow, leaves, etc. to the Jellyfin web interface.",
+    "overview": "Seasonal effects for Jellyfin",
+    "owner": "CodeDevMLH",
+    "category": "General",
+    "imageUrl": "https://git.mahom03-spacecloud.de/CodeDevMLH/Jellyfin-Seasonals-Plugin/raw/branch/main/logo.png",
+    "versions": [
+      {
+        "version": "1.0.0.0",
+        "changelog": "Initial release",
+        "targetAbi": "10.11.0.0",
+        "sourceUrl": "https://git.mahom03-spacecloud.de/CodeDevMLH/Jellyfin-Seasonals-Plugin/releases/download/v1.0.0.0/Jellyfin.Plugin.Seasonals.zip",
+        "checksum": "be6d06a959b3e18e5058a6d8fb6d800c",
+        "timestamp": "2025-12-15T15:33:15Z"
+      }
+    ]
+  }
+]

manifest.json

@@ -8,6 +8,22 @@
     "category": "General",
     "imageUrl": "https://git.mahom03-spacecloud.de/CodeDevMLH/Jellyfin-Seasonals-Plugin/raw/branch/main/logo.png",
     "versions": [
+      {
+        "version": "1.2.0.0",
+        "changelog": "Bug fixing: Fix path, fix injection issue, added File Transformator as fallback if direct injection is blocked due to permissions.",
+        "targetAbi": "10.11.0.0",
+        "sourceUrl": "https://git.mahom03-spacecloud.de/CodeDevMLH/Jellyfin-Seasonals-Plugin/releases/download/v1.2.0.0/Jellyfin.Plugin.Seasonals.zip",
+        "checksum": "be2e93364396b6e0e02368d5a7db53bc",
+        "timestamp": "2025-12-17T15:32:08Z"
+      },
+      {
+        "version": "1.1.1.0",
+        "changelog": "Bug fixing: Added Advanced Configuration UI for customizing individual seasonal effects.",
+        "targetAbi": "10.11.0.0",
+        "sourceUrl": "https://git.mahom03-spacecloud.de/CodeDevMLH/Jellyfin-Seasonals-Plugin/releases/download/v1.1.1.0/Jellyfin.Plugin.Seasonals.zip",
+        "checksum": "f1d7e2b24ad474904fa0eb1749e855b0",
+        "timestamp": "2025-12-16T00:56:08Z"
+      },
       {
         "version": "1.1.0.0",
         "changelog": "Added Advanced Configuration UI for customizing individual seasonal effects.",