From daf26fe53a8152c3ff425844bb8a772a06af7f5e Mon Sep 17 00:00:00 2001 From: CodeDevMLH <145071728+CodeDevMLH@users.noreply.github.com> Date: Fri, 13 Feb 2026 19:42:49 +0100 Subject: [PATCH] Refactor slide playback logic to remove redundant checks and improve clarity --- .../Web/mediaBarEnhanced.js | 21 ++----------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/Jellyfin.Plugin.MediaBarEnhanced/Web/mediaBarEnhanced.js b/Jellyfin.Plugin.MediaBarEnhanced/Web/mediaBarEnhanced.js index b300cea..d61a956 100644 --- a/Jellyfin.Plugin.MediaBarEnhanced/Web/mediaBarEnhanced.js +++ b/Jellyfin.Plugin.MediaBarEnhanced/Web/mediaBarEnhanced.js @@ -1741,16 +1741,7 @@ const SlideCreator = { const slide = document.querySelector(`.slide[data-item-id="${itemId}"]`); const isVideoPlayerOpen = document.querySelector('.videoPlayerContainer') || document.querySelector('.youtubePlayerContainer'); - if (slide && slide.classList.contains('active') && !document.hidden && (!isVideoPlayerOpen || isVideoPlayerOpen.classList.contains('hide'))) { - // MARK: mark - const currentIndex = STATE.slideshow.currentSlideIndex; - const currentItemId = STATE.slideshow.itemIds[currentIndex]; - if (currentItemId !== itemId) { - console.log(`Slide ${itemId} is no longer active (current: ${currentItemId}), aborting playback.`); - event.target.mute(); // Mute just in case - return; - } - + if (slide && slide.classList.contains('active') && !document.hidden && (!isVideoPlayerOpen || isVideoPlayerOpen.classList.contains('hide'))) { event.target.playVideo(); // Check if it actually started playing after a short delay (handling autoplay blocks) @@ -1827,13 +1818,8 @@ const SlideCreator = { backdrop.addEventListener('play', (event) => { const slide = document.querySelector(`.slide[data-item-id="${itemId}"]`); - // MARK: mark - const currentIndex = STATE.slideshow.currentSlideIndex; - const currentItemId = STATE.slideshow.itemIds[currentIndex]; - - if (!slide || !slide.classList.contains('active') || currentItemId !== itemId) { - // if (!slide || !slide.classList.contains('active')) { + if (!slide || !slide.classList.contains('active')) { console.log(`Local video ${itemId} started playing but is not active, pausing.`); event.target.pause(); event.target.currentTime = 0; @@ -2712,9 +2698,7 @@ const SlideshowManager = { videoBackdrop.play().catch(() => { setTimeout(() => { - // MARK: mark if (videoBackdrop.paused && slide.classList.contains('active')) { - // if (videoBackdrop.paused) { console.warn(`Autoplay blocked for ${itemId}, attempting muted fallback`); videoBackdrop.muted = true; videoBackdrop.play().catch(err => console.error("Muted fallback failed", err)); @@ -2741,7 +2725,6 @@ const SlideshowManager = { } setTimeout(() => { - // MARK: mark if (!slide.classList.contains('active')) return; if (player.getPlayerState &&